fix(ui): Fix greediness in regex for auth token replacement

[mruoss]

Checklist:

• My organization is added to USERS.md.

Unfortunately my last PR #5677 still has a little bug in the regular expression. The auth token we get from the cookie is sometimes wrapped by quotes (") and sometimes it is not. Therefore the regex wraps the matched token with optional quotes ("?(.*)"?). This regex matches"token" such as token. The problem is the first case ("token"). In this case the captured bit inside the parentheses would also match the second quote (token") because the part inside the parentheses ((.*)) matches all characters greedily. This can be fixed by matching lazily (.*?) as proposed in the Merge request.

Sorry for this - I guess the screenshot testing was not successful. Nevertheless here's more screenshots of the running system before and after my fix:

before:

after:

[codecov]

Codecov Report

Merging #5746 (6c07870) into master (284adfe) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5746      +/-   ##
==========================================
+ Coverage   46.75%   46.83%   +0.07%     
==========================================
  Files         244      244              
  Lines       15270    15270              
==========================================
+ Hits         7139     7151      +12     
+ Misses       7227     7213      -14     
- Partials      904      906       +2     

Impacted Files	Coverage Δ
cmd/argo/commands/get.go	56.31% <0.00%> (+0.64%)	⬆️
server/workflow/workflow_server.go	42.73% <0.00%> (+2.27%)	⬆️
workflow/metrics/server.go	16.66% <0.00%> (+4.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284adfe...6c07870. Read the comment docs.

[alexec]

Thank you!