fix(ui): Fix greediness in regex for auth token replacement #5746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Unfortunately my last PR #5677 still has a little bug in the regular expression. The auth token we get from the cookie is sometimes wrapped by quotes (
"
) and sometimes it is not. Therefore the regex wraps the matched token with optional quotes ("?(.*)"?
). This regex matches"token"
such astoken
. The problem is the first case ("token"
). In this case the captured bit inside the parentheses would also match the second quote (token"
) because the part inside the parentheses ((.*)
) matches all characters greedily. This can be fixed by matching lazily (.*?
) as proposed in the Merge request.Sorry for this - I guess the screenshot testing was not successful. Nevertheless here's more screenshots of the running system before and after my fix:
before:
after: