fix(executor): GODEBUG=x509ignoreCN=0 #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #5562 +/- ##
==========================================
- Coverage 47.04% 47.01% -0.03%
==========================================
Files 240 240
Lines 15013 15016 +3
==========================================
- Hits 7063 7060 -3
- Misses 7052 7058 +6
Partials 898 898
Continue to review full report at Codecov.
|
whynowy
approved these changes
Mar 31, 2021
workflow/controller/workflowpod.go
Outdated
| @@ -535,6 +535,13 @@ func (woc *wfOperationCtx) createEnvVars() []apiv1.EnvVar { | |||
| Name: common.EnvVarContainerRuntimeExecutor, | |||
| Value: woc.getContainerRuntimeExecutor(), | |||
| }, | |||
| // This flag was introduced in Go 16 and will be removed in Go 16. | |||
|
Next steps.
|
|
@simster7 @sarabala1979 this appears to have fixed the issue on GCP. |
simster7
pushed a commit
that referenced
this pull request
Apr 1, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
simster7
pushed a commit
that referenced
this pull request
Apr 5, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this,lets merge it and make sure https://workflows.apps.argoproj.io/ can run coin flip