Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated README.md #5560

Merged
merged 1 commit into from
Mar 31, 2021
Merged

docs: Updated README.md #5560

merged 1 commit into from
Mar 31, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 31, 2021

No description provided.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #5560 (79ee3d3) into master (23ccd9c) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 79ee3d3 differs from pull request most recent head b19af60. Consider uploading reports for the commit b19af60 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5560      +/-   ##
==========================================
- Coverage   47.03%   46.97%   -0.06%     
==========================================
  Files         240      240              
  Lines       15013    15013              
==========================================
- Hits         7061     7052       -9     
- Misses       7054     7061       +7     
- Partials      898      900       +2     
Impacted Files Coverage Δ
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️
cmd/argo/commands/get.go 56.66% <0.00%> (-0.67%) ⬇️
workflow/controller/operator.go 70.69% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ccd9c...b19af60. Read the comment docs.

@@ -2,51 +2,93 @@
[![CI](https://github.com/argoproj/argo-workflows/workflows/CI/badge.svg)](https://github.com/argoproj/argo-workflows/actions?query=event%3Apush+branch%3Amaster)
[![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/3830/badge)](https://bestpractices.coreinfrastructure.org/projects/3830)

![Argo Image](docs/assets/argo.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should keep the logo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it pushes a lot of content below the fold - and we have the logo on the page elsewhere


## Ecosystem

![Ecosystem](docs/assets/ecosystem.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@alexec alexec merged commit 17ff2c1 into argoproj:master Mar 31, 2021
@alexec alexec deleted the docs branch March 31, 2021 22:31
@simster7 simster7 mentioned this pull request Apr 1, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants