Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add Zhihu as user #5555

Merged
merged 1 commit into from
Mar 31, 2021
Merged

docs: Add Zhihu as user #5555

merged 1 commit into from
Mar 31, 2021

Conversation

iven
Copy link
Contributor

@iven iven commented Mar 31, 2021

Checklist:

@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #5555 (3ffa048) into master (20f0047) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5555      +/-   ##
==========================================
- Coverage   47.04%   47.03%   -0.02%     
==========================================
  Files         240      240              
  Lines       15012    15012              
==========================================
- Hits         7063     7061       -2     
- Misses       7051     7053       +2     
  Partials      898      898
Impacted Files Coverage Δ
workflow/metrics/server.go 12.50% <0.00%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f0047...3ffa048. Read the comment docs.

@iven
docs: Add Zhihu as user
3ffa048 
Signed-off-by: Iven Hsu <ivenvd@gmail.com>
terrytangyuan
terrytangyuan approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! 🎉

@simster7 simster7 merged commit 26ca3fa into argoproj:master Mar 31, 2021
@simster7 simster7 mentioned this pull request Apr 1, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iven @simster7 @terrytangyuan