feat: Retry creating wftmpl that references another wftmpl in the same operation #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e operation Signed-off-by: Simon Behar <simbeh7@gmail.com>
simster7
commented
Feb 25, 2021
| created, err := serviceClient.CreateWorkflowTemplate(ctx, &workflowtemplatepkg.WorkflowTemplateCreateRequest{ | ||
| Namespace: wftmpl.Namespace, | ||
| Template: &wftmpl, | ||
| }) |
There was a problem hiding this comment.
Looking for feedback for this solution. If feedback is good, then I will move to clean the code, add it to other similar areas (e.g. ClusterWorkflowTemplates), and add test.
|
I think |
I presume you mean This PR took me around 30 minutes to do, btw. |
|
Closing for now |
|
hi. this is still an issue in Argo v3.1.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5173
Looking for feedback for this solution. If feedback is good, then I will move to clean the code, add it to other similar areas (e.g.
ClusterWorkflowTemplates), and add test.I initially considered doing topographical sorting on all the workflow templates before attempting to create this. However, that gets a bit messy (have to consider, for example, all steps of all templates of all WorkflowTemplates to look for references). Also, since I expect this use case to come up infrequently, I prefer a "lazy" approach where we only engage this code if we need to.