Harden the IsURL check #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IsURL check simply called url.ParseRequestURI and relied on whether it errors or not to detect whether the given string is a url or not. Turns out that url.ParseRequestURI does not error out if the given string is a complete filesystem path /path/to/file. This commit hardens the IsURL check. It checks whether the returned URL object by url.ParseRequestURI() has an actual Host component or not. If not, isURL returns false. Refs argoproj#509.
jessesuen
approved these changes
Dec 1, 2017
icecoffee531
pushed a commit
to icecoffee531/argo-workflows
that referenced
this pull request
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IsURL check simply called url.ParseRequestURI and relied on whether it errors
or not to detect whether the given string is a url or not. Turns out that
url.ParseRequestURI does not error out if the given string is a complete
filesystem path /path/to/file.
This commit hardens the IsURL check. It checks whether the returned URL object
by url.ParseRequestURI() has an actual Host component or not. If not, isURL returns
false.
Testing Done:
argo submit failed with a full-path prior to this change. Worked after.
argo submit succeeded with a url before and after.
Refs #509.