fix: Synchronization lock handling in Step/DAG Template level #5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
sarabala1979
commented
Feb 10, 2021
| woc.controller.syncManager.Release(woc.wf, node.ID, tmpl.Synchronization) | ||
| } | ||
| } else { | ||
| if !sgNode.Fulfilled() { |
There was a problem hiding this comment.
This is a bug. Code is releasing parent lock if child completes
sarabala1979
commented
Feb 10, 2021
| @@ -1785,6 +1785,12 @@ func (woc *wfOperationCtx) executeTemplate(ctx context.Context, nodeName string, | |||
| } | |||
| } | |||
|
|
|||
| if node.Fulfilled() { | |||
There was a problem hiding this comment.
This is the right place to check the node status and release the lock.
alexec
reviewed
Feb 11, 2021
alexec
reviewed
Feb 11, 2021
There was a problem hiding this comment.
Good work. I love how thorough your tests are.
Can I make an ask?
I see this logged a lot:
controller | time="2021-02-11T08:36:08.398Z" level=info msg="Check the workflow existence"
Could we either:
- Make this DEBUG?
- Add some fields to it to give it a bit more context? Currently I need to look at the source code to understand it. Most users will not do that.
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
alexec
approved these changes
Feb 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: