Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Upgrade to argosay:v2 #3001

Merged
merged 1 commit into from
May 11, 2020
Merged

test: Upgrade to argosay:v2 #3001

merged 1 commit into from
May 11, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 11, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec marked this pull request as ready for review May 11, 2020 18:05
@alexec
Copy link
Contributor Author

alexec commented May 11, 2020

This can be merged as soon as approved.

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

simster7
simster7 approved these changes May 11, 2020
View reviewed changes
config/config.go
DisableLegacy bool `json:"disableLegacy"`
MetricsTTL TTL `json:"metricsTTL"`
Enabled bool `json:"enabled"`
DisableLegacy bool `json:"disableLegacy,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@alexec alexec merged commit eefe120 into argoproj:master May 11, 2020
@alexec alexec deleted the test-argosay-v2 branch May 11, 2020 20:32
alexec added a commit to alexec/argo-workflows that referenced this pull request May 11, 2020
@alexec
test: Upgrade to argosay:v2 (argoproj#3001)
4593d9a
@agilgur5 agilgur5 mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

@sarabala1979 sarabala1979 Awaiting requested review from sarabala1979

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @simster7