feat(controller)!: Updates the resource duration calculation. Fixes #2934 #2937
Conversation
|
@elgalu, @gaigepr, @seichten, @lemor303442, @paguos, @goern, @wangadong, @phelinor, @ddseapy, @zhujl1991 can I please request your feedback on this change? |
alexec
changed the title
|
@elgalu, @gaigepr, @seichten, @lemor303442, @paguos, @goern, @wangadong, @phelinor, @zhujl1991 bump! |
| @@ -56,9 +56,6 @@ type Config struct { | |||
| // MetricsConfig specifies configuration for metrics emission | |||
| MetricsConfig PrometheusConfig `json:"metricsConfig,omitempty"` | |||
|
|
|||
| // FeatureFlags for general/experimental features | |||
| FeatureFlags FeatureFlags `json:"featureFlags,omitempty"` | |||
There was a problem hiding this comment.
Are we getting rid of feature flags entirely? Wouldn't we want to keep this for future features?
There was a problem hiding this comment.
I don't think it is bad design. You can use normal config item or a envvar? Both are easier and more flexible.
There was a problem hiding this comment.
Are we enabling resource duration by default?
| @@ -978,7 +979,7 @@ func (in ResourcesDuration) Add(o ResourcesDuration) ResourcesDuration { | |||
| func (in ResourcesDuration) String() string { | |||
| var parts []string | |||
| for n, d := range in { | |||
| parts = append(parts, fmt.Sprintf("%v*%s", d, n)) | |||
| parts = append(parts, fmt.Sprintf("%v*(%s %s)", d, ResourceQuantityDenominator(n).String(), n)) | |||
There was a problem hiding this comment.
This looks way better in my opinion
|
Kudos, SonarCloud Quality Gate passed!
|
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Fixes #2934
Changes
Screenshots