fix(ui): fix BASE_HREF in production index.html. Fixes #15046 #15066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argoproj#14894 introduced a bug where the `ui/dist/app/index.html` file generated during production builds has a script tag of the form `<script defer="defer" src="/main.<HASH>.js">`, whereas it was previously `<script defer="defer" src="main.<HASH>.js">`. This is because the production build process that generates `ui/dist/app/index.html` never has `ARGO_BASE_HREF` set, so `output.publicPath` defaulted to `/` (the previous default was `auto`). We only need to set `publicPath` for the development build, so I moved the setting to the `devServer.devMiddleware.publicPath`. Tested locally using `make start UI=true BASE_HREF=/argo/` and `make start UI=true` and verifying the workflows page loads in both. Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Closed
4 tasks
Joibel
approved these changes
Nov 24, 2025
guanguxiansheng
pushed a commit
to guanguxiansheng/argo-workflows
that referenced
this pull request
Dec 15, 2025
…argoproj#15066) Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
|
🍒 Cherry-pick PR created for 3.7: #15215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15046
Motivation
#14894 introduced a bug where the
ui/dist/app/index.htmlfile generated during production builds has a script tag of the form<script defer="defer" src="/main.<HASH>.js">, whereas it was previously<script defer="defer" src="main.<HASH>.js">.This is because the production build process that generates
ui/dist/app/index.htmlnever hasARGO_BASE_HREFset, sooutput.publicPathwas set to/. The default for that setting isauto(docs).Modifications
We only need to set
publicPathfor the development build, so I moved the setting todevServer.devMiddleware.publicPath(docs).Verification
Tested locally using
make start UI=true BASE_HREF=/argo/andmake start UI=trueand verifying the workflows page loads in both.Documentation
N/A