Skip to content

Conversation

@Joibel
Copy link
Member

@Joibel Joibel commented Mar 7, 2025

A lesser version of #14189

Motivation

As part of 3.6 we deprecated 4 features. This removes one of them completely

  • podPriority doesn't work any modern kubernetes and has been deprecated for a while

It also updates where possible to only use plural schedules, mutexes and semaphores.

Removing legacy code reduces maintainer burden and the chance for errors.

Modifications

Removed priority/podPrirority
Removed podPriority tests.
Updated all tests which used the 3 deprecated features to use the new version where it makes sense.

Verification

Relying on updated tests.

Documentation

Updated to use plural and the rest is regenerated automatically.

@Joibel Joibel force-pushed the priority-removal branch 3 times, most recently from c6acb96 to ceaa675 Compare March 7, 2025 13:57
Signed-off-by: Alan Clucas <alan@clucas.org>
@Joibel Joibel force-pushed the priority-removal branch from ceaa675 to bbd97cc Compare March 7, 2025 14:14
@Joibel Joibel marked this pull request as ready for review March 7, 2025 15:58
@Joibel Joibel requested a review from isubasinghe March 10, 2025 08:24
@isubasinghe isubasinghe merged commit 0467e54 into argoproj:main Mar 11, 2025
31 checks passed
@Joibel Joibel deleted the priority-removal branch March 11, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants