docs: fix kubernetes versions #14274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Clucas <alan@clucas.org>
MasonM
approved these changes
Mar 10, 2025
| ./hack/docs/check-env-doc.sh | ||
| # build the docs | ||
| ifeq ($(RELEASE_TAG),true) | ||
| ifeq ($(shell echo $(GIT_BRANCH) | head -c 8),release-) |
Member
There was a problem hiding this comment.
I actually started off doing this, but went with the release tag approach because you mentioned concerns in #14176 (comment) that an update to the k8s version may have occurred on the branch without a release. I'm assuming that's rare enough this isn't a big problem.
I did start on a branch to fully automate this using the peter-evans/create-pull-request action, though I'm not sure it's worth it, and determining the branch name from the release tag turned out to be a bit more complicated than I expected:
main...MasonM:argo-workflows:automate-docs-update
terrytangyuan
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kubernetes versions in documentation - this doesn't work as hoped from #14176
Motivation
Docs get rebuilt on every push to a branch, so
RELEASE_TAGisn't usableModifications
Use the
GIT_BRANCHvariable and check we're on an appropriate branchVerification
make docsDocumentation
Not needed