Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(artifacts): add git https insecure option. Fixes #10762 #13797

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(artifacts): add git https insecure option. Fixes #10762 #13797

wants to merge 2 commits into from
+1,290 −704

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Oct 22, 2024 •
edited
Loading

Replaces #10543
Fixes #10762

Motivation

Add support for skipping TLS verification when cloning Git repositories over HTTPS in Argo Workflows. This is useful for scenarios involving self-signed certificates or internal Git servers where full TLS verification might not be possible or desired.

Modifications

  • Added new InsecureSkipTLS boolean field to GitArtifact struct in workflow types
  • Extended the Git artifact driver to support the new InsecureSkipTLS option
  • Propagated the setting through to the underlying git clone operation

Verification

  • Tested git clone operations with self-signed certificates:
    • Verified successful cloning with insecureSkipTLS: true
    • Verified expected TLS verification behavior with insecureSkipTLS: false
  • Ensured backward compatibility with existing Git artifact configurations
  • Verified the new field is properly serialized/deserialized in workflow specs

@aslafy-z aslafy-z force-pushed the patch-2 branch 3 times, most recently from 9089549 to 9926d80 Compare October 22, 2024 11:04
@aslafy-z aslafy-z mentioned this pull request Oct 22, 2024
Closed
8 tasks
@aslafy-z aslafy-z marked this pull request as ready for review October 22, 2024 14:59
@aslafy-z aslafy-z force-pushed the patch-2 branch 2 times, most recently from 8a2b5c2 to 2b530fe Compare October 22, 2024 15:02
@aslafy-z
feat(artifacts): add git https insecure option
aa668b1 
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
@aslafy-z
chore(artifacts): codegen
ec01235 
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan is a code owner

@sarabala1979 sarabala1979 Awaiting requested review from sarabala1979 sarabala1979 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support disabling TLS verify for Git artifacts retrieval
1 participant
@aslafy-z