docs: mark generated python SDK as deprecated #13719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
reviewed
Oct 7, 2024
There was a problem hiding this comment.
sdks/python/README.md should also be updated
There are already two good alternatives for using python to create workflows
Couler does not seem to be actively maintained, but yes Hera ofc is
and probably others
yea there's a small mountain of bugs with the SDKs; some of which are resolved in updating the OpenAPI generator, which is itself a breaking change 🙃
agilgur5
changed the title
Signed-off-by: Alan Clucas <alan@clucas.org>
Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
force-pushed
the
python-sdk-deprecate
branch
from
bc33dfb
to
a9ee8b5
Compare
Eugh, I don't know how I missed this one. Thanks.
I've reordered the list and pushed for hera being the suggestion a bit more heavily. |
agilgur5
reviewed
Oct 14, 2024
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
agilgur5
approved these changes
Oct 14, 2024
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13703
Motivation
The Python SDK is auto-generated, and the maintainers of argo-workflows do not wish to invest their limited time improving this situation. There are already two good alternatives for using python to create workflows
This will allow us to close
and probably others
Modifications
The main change is to mark the SDK as deprecated in client-libraries.md, and give a planned removal in 3.7.
There should be a follow up once
release/3.6is branched to actually remove the generation of the code.Verification
make docspasses