Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade go-to-protobuf to v0.30.5. Fixes #13620 #13653

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

build: upgrade go-to-protobuf to v0.30.5. Fixes #13620 #13653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ $(GOPATH)/bin/go-to-protobuf: Makefile
ifneq ($(USE_NIX), true)
# TODO: currently fails on v0.30.3 with
# Unable to clean package k8s.io.api.core.v1: remove /home/runner/go/pkg/mod/k8s.io/api@v0.30.3/core/v1/generated.proto: permission denied
go install k8s.io/code-generator/cmd/go-to-protobuf@v0.21.5
go install k8s.io/code-generator/cmd/go-to-protobuf@v0.30.5
Copy link
Member

@agilgur5 agilgur5 Sep 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codegen is failing. If you're able to fix it, you should also remove the above comments

endif
$(GOPATH)/src/github.com/gogo/protobuf: Makefile
# update this in Nix when upgrading it here
Expand Down
Loading