refactor(tests): assert.Error -> require.Error (other unit tests)
#13399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
changed the title
assert.Error -> require.Error (other unit tests)
This is part of a series of test tidies started by #13365. The aim is to enable the testifylint golangci-lint checker. This commit converts assert.Error checks into require.Error for the part of the codebase, as per #13270 (comment) In some places checks have been coaleced - in particular the pattern ```go if assert.Error() { assert.Contains(..., "message") } ``` is now ```go require.ErrorContains(..., "message") ``` Getting this wrong and missing the Contains is still valid go, so that's a mistake I may have made. Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
force-pushed
the
testifylint-require-other
branch
from
e4ec409
to
86c259e
Compare
agilgur5
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of test tidies started by #13365.
The aim is to enable the
testifylintgolangci-lintchecker.This commit converts
assert.Errorchecks intorequire.Errorfor the part of the codebase, as per #13270 (comment)In some places checks have been coalesced - in particular the pattern
is now
Getting this wrong and missing the
Containsis still valid Go, so that's a mistake I may have made.Signed-off-by: Alan Clucas alan@clucas.org