fix(server): switch to JSON_EXTRACT and JSON_UNQUOTE for MySQL/MariaDB. Fixes #13202

[spaced]

fix: use standard JSON_EXTRACT and JSON_UNQUOTE function for list workflow using mariadb. Fixes #13202

--> is only a alias to JSON_EXTRACT() function

(The -> operator serves as an alias for the JSON_EXTRACT()

for some fields it was even wrong (for example it makes no sense to unquote the $.metadata.labels.
mariadb does not support this (see feature request in mariadb: https://jira.mariadb.org/browse/MDEV-13594)

Fixes #13202
Follow-up to #12912

Motivation

be compatible with mariadb

Modifications

• replace -> with JSON_EXTRACT
• replace --> with JSON_UNQUOTE(JSON_EXTRACT(..,..)

Verification

locally

[agilgur5]

@jiachengxu could you review/double-check this? Thanks again for all your follow-ups ❤️

[terrytangyuan]

The changes make sense but I wonder if we should introduce additional e2e test suits for other DBs for compatibility

[jiachengxu]

The change looks good to me, and to Terry's point, I think it makes sense to add e2e tests for DB compatibility

[spaced]

@terrytangyuan @jiachengxu should the e2e test with mariab part of this PR or anything else is needed to get merged? It would be also nice if this can be back ported to version 3.5.x.

[agilgur5]

It would be also nice if this can be back ported to version 3.5.x.

We'd do that automatically as it's a fix 👍
I'm also release managing 3.5.x right now and so also know to backport it when merged.

should the e2e test with mariab part of this PR or anything else is needed to get merged?

IMO, I think this is fine as-is since it fixes an unintended compatibility regression (although really should be on MariaDB to be compatible, no?). Tests would be great to add, but we pretty rarely change DB queries, I'd be fine if they're added later. We also currently only test MySQL in CI and don't test Postgres either. Adding MariaDB requires a new manifest and profile as well, so it's a non-trivial change (substantially larger than this PR)
@terrytangyuan are you fine with that?