Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: copy-edit of Steps page #13157

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

agilgur5
Copy link
Member

@agilgur5 agilgur5 commented Jun 9, 2024

Fixes #9907 (comment), which I discovered after going through all old Giscus discussions per #13138 "Future Work"
Aligns with my other copy-edits of docs pages

Motivation

Simplify various sentences in the page, follow the style guide, and improve some confusing bits

Modifications

  • specify which CLI command to use, and link to the reference for it as well

    • this has confused readers in the past, especially beginners
  • refer to the reader as "you", per k8s style guide

  • simplify several sentences, per k8s style guide

  • prefer 1 sentence per line of markdown, per style guide

Verification

make docs passes

- specify _which_ CLI command to use, and link to the reference for it as well
  - this has confused readers in the past, especially beginners

- refer to the reader as "you", per [k8s style guide](https://kubernetes.io/docs/contribute/style/style-guide/#address-the-reader-as-you)
- simplify several sentences, per [k8s style guide](https://kubernetes.io/docs/contribute/style/style-guide/#use-simple-and-direct-language)
- prefer 1 sentence per line of markdown, per [style guide](https://argo-workflows.readthedocs.io/en/release-3.5/doc-changes/)

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
@agilgur5 agilgur5 added area/docs Incorrect, missing, or mistakes in docs area/templates/steps labels Jun 9, 2024
@Joibel Joibel merged commit 55e2c7c into argoproj:main Jun 10, 2024
19 checks passed
@agilgur5 agilgur5 deleted the docs-steps-copy-edit branch June 10, 2024 14:46
@agilgur5 agilgur5 added this to the v3.4.x patches milestone Jun 10, 2024
agilgur5 added a commit that referenced this pull request Jun 14, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
(cherry picked from commit 55e2c7c)
agilgur5 added a commit that referenced this pull request Jun 14, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
(cherry picked from commit 55e2c7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs area/templates/steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants