fix: load missing fields for archived workflows #13136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiachengxu
force-pushed
the
list-workflow-fields
branch
2 times, most recently
from
9365e0f
to
b07ba7e
Compare
Signed-off-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com>
jiachengxu
force-pushed
the
list-workflow-fields
branch
from
b07ba7e
to
6f2ac80
Compare
terrytangyuan
approved these changes
Jun 3, 2024
agilgur5
pushed a commit
that referenced
this pull request
Jun 14, 2024
Signed-off-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> (cherry picked from commit b212d5f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/argoproj/argo-workflows/pull/12912/files#r1572901283
This PR loads
status.message,status.estimatedDuration,status.resourceDuration, andspec.suspendfor archived workflows, since UI may need them based on workflows-service.ts and reports.tsx.