fix: upgrade argo-ui components to latest -- 3.4 backport
#12998
+787
−581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cherry pick of argoproj#11585 to release/3.4 Changes from argoproj#11585: * `archived-workflow-details.tsx` changes to `className` * `yarn.lock` updated, `react-toastify` still pinned to 9.0.3 Co-authored-by: Anton Gilgur <agilgur5@gmail.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Alan Clucas <alan@clucas.org>
agilgur5
changed the title
argo-ui components to latestargo-ui components to latest (3.4 cherry pick)
agilgur5
added
type/dependencies
agilgur5
changed the title
argo-ui components to latest (3.4 cherry pick)argo-ui components to latest (3.4 backport)
agilgur5
approved these changes
May 4, 2024
There was a problem hiding this comment.
It looks like there was a merge conflict resolution mistake here (see below in-line comment) that updated some devDeps unnecessarily, but it doesn't actually impact anything meaningful. Otherwise changes LGTM.
Checked locally that I produced the same yarn.lock as is here as well and ran yarn test and yarn lint since CI isn't running on the release-3.4 base branch. All made no changes. Generated files LGTM.
| "babel-loader": "^8.3.0", | ||
| "copy-webpack-plugin": "^5.1.2", | ||
| "copyfiles": "^2.4.1", | ||
| "file-loader": "^6.2.0", | ||
| "glob": "^9.3.2", | ||
| "glob": "^10.3.3", |
There was a problem hiding this comment.
Oh right, and then I removed glob in #11630 anyway as it was unused
4 tasks
agilgur5
changed the title
argo-ui components to latest (3.4 backport)argo-ui components to latest -- 3.4 backport)
agilgur5
changed the title
argo-ui components to latest -- 3.4 backport)argo-ui components to latest -- 3.4 backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cherry pick of #11585 to release/3.4
Changes from #11585:
archived-workflow-details.tsxchanges toclassNameyarn.lockupdated,react-toastifystill pinned to 9.0.3Specifically fixes #11448 on 3.4
Fixes #11585 missing from #11648 (comment)
Testing
make start UI=trueruns up cleanly.Built argo-cli image and installed it as the UI in a 3.4.16 install. Ran a workflow and clicked around a lot. I didn't observe anything wrong.
The resolution #11448 has been checked.