ci(deps): fix deduplication commit for yarn.lock for Dependabot PRs
#12882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previously it would fail if there were no changes so add `--allow-empty` to the commit as a quick fix - also add `name`s to these steps for clarity Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
area/build
This was referenced Apr 4, 2024
terrytangyuan
approved these changes
Apr 4, 2024
agilgur5
commented
Apr 4, 2024
agilgur5
changed the title
yarn.lock for Dependabot PRsyarn.lock for Dependabot PRs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12880 (comment), #12234 (comment)
Motivation
--allow-emptyto the commit as a quick fixModifications
--allow-emptyto thegit commitfor deduplicated Dependabot PRsnames to these steps for clarity (per chore(deps): bumpexpress,follow-redirects, andwebpack-dev-middleware#12880 (comment), following ci: better naming for various steps/jobs #11752)Verification
Tested this locally and it worked and exited cleanly (exit code
0):git add ui/yarn.lock git commit -s --allow-empty -m 'chore: deduplicate yarn.lock'Future Work
yarn.lockyarn-deduplicateon dependabot PRs #12892 so this is no longer actionable; marked as completed as such