docs: consolidate expression links #12617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- most of these should go to the definition in Argo's own docs in `variables.md#expression` - use https://expr-lang.org/docs/language-definition instead of GH as it has nicer UX - while at it, make some small docs changes in the same place - more simple and direct, per [k8s style guide](https://kubernetes.io/docs/contribute/style/style-guide/#use-simple-and-direct-language) - some of these, especially the `data` one, were incredibly overly verbose and have been greatly simplified - use present tense, per [k8s style guide](https://kubernetes.io/docs/contribute/style/style-guide/#use-present-tense) - prefer 1 sentence per line, per [style guide](https://argo-workflows.readthedocs.io/en/release-3.5/doc-changes/) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
area/docs
This was referenced Feb 4, 2024
agilgur5
added a commit
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com> (cherry picked from commit 0cd37f2)
|
Backported cleanly to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12469 (comment) and #12573 (comment)
Motivation
variables.md#expressionModifications
change internal docs references to expressions to go to
variables.md#expression, the internal docs definition of itchange external references to go to https://expr-lang.org/docs/language-definition
while at it, make some small docs changes in the same place
dataone, were incredibly overly verbose and have been greatly simplifiedVerification
make docspasses