Set executor log level #1226
Closed
Set executor log level #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtaniwaki actually with PR #1214, this will be supported. I added flag in executor and the ability to set additional args and environment variables in the workflow-controller-configmap |
|
@jessesuen Thank you for implementing it. It’s totally fine if I can configure the log level. |
|
With PNS merged, I think we can close this. This is how we can add log level arguments to executor: |
|
Thanks! |
icecoffee531
pushed a commit
to icecoffee531/argo-workflows
that referenced
this pull request
Jan 5, 2022
* chore: Fix make command (argoproj#1221) target "all" was replaced by "build" in argoproj#1203 Signed-off-by: Stephan van Maris <s.vanmaris@teamitg.com> * feat: added expr filter logic and tests Signed-off-by: Vaibhav Page <vaibhav.page@gmail.com> * chore: codegen Signed-off-by: Vaibhav Page <vaibhav.page@gmail.com> * chore: codegen Signed-off-by: Vaibhav Page <vaibhav.page@gmail.com> Co-authored-by: Stephan van Maris <s.vanmaris@e-village.nl> Co-authored-by: Derek Wang <whynowy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use logrus in the executor, but there's no way to control the log level. I think we can have a config for it.