ci: ensure least privilege permissions for GHA tokens #12035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is an [OpenSSF Scorecard check](https://github.com/ossf/scorecard/blob/8eaf0d7647a3f50d80615812c72a277fd568fb6d/docs/checks.md#token-permissions) - default to `permissions.contents: read` for read-only permissions for a GHA Workflow - this was missing from `pr.yaml` and was `write` for `docs.yaml` - only add needed permissions per specific GHA Job - move the `permissions.contents: write` for `docs.yaml` into the `docs:` Job - also add comments for why all permissions are needed Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
type/security
7 tasks
terrytangyuan
approved these changes
Oct 19, 2023
5 tasks
agilgur5
added a commit
that referenced
this pull request
May 27, 2024
(cherry picked from commit 247448c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #12031, Token Permissions
Motivation
Modifications
Basically follow the OpenSSF Scorecard directions
default to
permissions.contents: readfor read-only permissions for a GHA Workflowpr.yamland waswritefordocs.yamlonly add needed permissions per specific GHA Job
permissions.contents: writefordocs.yamlinto thedocs:Jobalso add comments for why all permissions are needed
Verification
pr.yamlstill successfully runs on this PRdocs.yamlhas no real semantic changes since there was only 1 GHA job there anyway