Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump typescript from 4.9.5 to 5.2.2 in /ui #11695

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 28, 2023

Bumps typescript from 4.9.5 to 5.2.2.

Release notes

Sourced from typescript's releases.

TypeScript 5.2

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.2 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.2 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on npm.

TypeScript 5.1.6

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on npm

TypeScript 5.1.5

... (truncated)

Commits
  • 9684ba6 Cherry-pick fix for cross-file inlay hints (#55476) to release-5.2 and LKG ...
  • 555ef99 Bump version to 5.2.2 and LKG
  • 6074b9d Update LKG for 5.2.1 RC.
  • b778ed1 Merge commit 'e936eb13d2900f21d79553c32a704307c7ad03dd' into release-5.2
  • 10b9962 Bump version to 5.2.1-rc and LKG
  • e936eb1 Update package-lock.json
  • e36cd57 Update package-lock.json
  • 581fba1 Update package-lock.json
  • 8fc8c95 Decorators normative updates (#55276)
  • b1c4dc4 Fix class name references (#55262)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.9.5 to 5.2.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.9.5...v5.2.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added type/dependencies PRs and issues specific to updating dependencies javascript Pull requests that update Javascript dependencies labels Aug 28, 2023
@github-actions github-actions bot enabled auto-merge (squash) August 28, 2023 21:29
@agilgur5
Copy link
Member

agilgur5 commented Sep 7, 2023

This is failing on compiling a component in argo-ui.

Logs:

ERROR in /home/runner/work/argo-workflows/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx
./node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx 65:24-72
[tsl] ERROR in /home/runner/work/argo-workflows/argo-workflows/ui/node_modules/argo-ui/src/components/autocomplete/autocomplete.tsx(65,25)
      TS2322: Type '"no-autocomplete"' is not assignable to type 'AutoFill'.
 @ ./node_modules/argo-ui/src/components/index.ts 58:13-51
 @ ./node_modules/argo-ui/src/index.ts 32:13-36
 @ ./src/app/app.tsx 27:16-34
 @ ./src/app/index.tsx 33:25-49 28:12-28

I imagine that the component may not be fully compatible with newer TS from this version.
Since the TS in argo-ui is not compiled, a versioning issue like this is something I warned about in #11510 (comment)

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 27, 2023

Looks like typescript is no longer updatable, so this is no longer needed.

@dependabot dependabot bot closed this Nov 27, 2023
auto-merge was automatically disabled November 27, 2023 17:30

Pull request was closed

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ui/typescript-5.2.2 branch November 27, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants