Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always fail dag when shutdown is enabled. Fixes #11452 #11667

Merged

Conversation

isubasinghe
Copy link
Member

@isubasinghe isubasinghe commented Aug 24, 2023

This will not build until #11665 is merged

isubasinghe and others added 5 commits August 24, 2023 19:18
Signed-off-by: isubasinghe <isitha@pipekit.io>
Signed-off-by: isubasinghe <isitha@pipekit.io>
Signed-off-by: isubasinghe <isitha@pipekit.io>
Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
@isubasinghe isubasinghe marked this pull request as ready for review August 24, 2023 09:23
@isubasinghe
Copy link
Member Author

Blocked by #11665

@terrytangyuan terrytangyuan merged commit 02d1e1f into argoproj:release-3.4.11 Aug 24, 2023
1 of 2 checks passed
@agilgur5 agilgur5 added the type/backport Backport of an existing PR to an older release branch label Mar 9, 2024
@agilgur5
Copy link
Member

agilgur5 commented Mar 9, 2024

Backport of #11493, for clarity / posterity

dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
…rgoproj#11667)

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
@agilgur5 agilgur5 added the area/shutdown Shutdown Strategy: Stop and Terminate label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/shutdown Shutdown Strategy: Stop and Terminate area/templates/dag type/backport Backport of an existing PR to an older release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants