-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resource): properly handle TERM signal after catch #11582
Conversation
…waiting so long to delete a pod Signed-off-by: feiyudev <feiyu.dev@gmail.com>
Thanks for fixing. Can you clarify where "argoexec resource" is invoked? |
When /usr/bin/containerd-shim-runc-v2 -namespace k8s.io -id <id> -address /run/containerd/containerd.sock
\_ /pause
\_ /var/run/argo/argoexec emissary --loglevel info --log-format text -- argoexec resource apply --loglevel debug
\_ /bin/argoexec resource apply --loglevel debug |
Thank you! I’m OOO right now but I’ll review next week when back if this hasn’t been merged by then. |
All right, thanks anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This seems to have effectively been a follow-up to #10523 (comment), if I'm understanding the history correctly |
argoproj#11582) Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
TERM signal was catched but not handled properly, which causing waiting so long to delete a pod
Fixes #10658
Motivation
pod can't be stopped via
argo terminate
, works after I changed the context.Modifications
changed the parent context in
argoexec resource
subcommand.Verification
kubectl delete pod
, no more 30s needed.argo terminate
works.