fix: do not process withParams when task/step Skipped. Fixes #10173 #11570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isubasinghe
force-pushed
the
withParams-fix-10173
branch
from
0774e6a
to
6178617
Compare
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
isubasinghe
force-pushed
the
withParams-fix-10173
branch
from
6178617
to
472254a
Compare
terrytangyuan
approved these changes
Aug 23, 2023
5 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Sep 5, 2023
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…#10173 (argoproj#11570) Signed-off-by: Isitha Subasinghe <isitha@pipekit.io> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10173
Verification
Tested locally and verified to be correct.