fix: azure hasLocation incorporates endpoint. Fixes #11512 #11513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roel Arents <roel.arents@kadaster.nl>
roelarents
force-pushed
the
fix-azure-haslocation
branch
from
0f9000e
to
ab06714
Compare
terrytangyuan
approved these changes
Aug 3, 2023
45 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Aug 11, 2023
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…rgoproj#11513) Signed-off-by: Roel Arents <roel.arents@kadaster.nl> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11512
Motivation
Make
AzureArtifact.hasLocationconsistent with the otherhasLocations.Modifications
Added check for an endpoint to
hasLocation. So an Azure Artifact is only considered to "have a location" if it has an endpoint, a container and a blob (key).Verification
I ran
executor.TestWorkflowExecutor_LoadArtifacts