Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make archived logs more human friendly in UI #11420

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

toyamagu-2021
Copy link
Member

Fixes #11419

Motivation

  • Make archived logs more human friendly

Modifications

  1. Fix the error message when we don't select a node.
    image
  2. Show node.displayName in logs.
    image

Verification

I've checked regressions.

Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
@terrytangyuan terrytangyuan merged commit f5d41f8 into argoproj:master Jul 22, 2023
22 checks passed
@toyamagu-2021 toyamagu-2021 deleted the fix-11419 branch July 22, 2023 16:34
@agilgur5 agilgur5 added the area/archive-logs Archive Logs feature label Apr 13, 2024
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request May 6, 2024
Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
@agilgur5 agilgur5 added this to the v3.4.x patches milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/archive-logs Archive Logs feature area/ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make archived logs more human friendly in UI
3 participants