-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow retry successful workflow if nodeFieldSelector is set. Fixes #11020 #11409
Merged
terrytangyuan
merged 1 commit into
argoproj:master
from
or-shachar:11020-retry-successful-workflows-cli
Jul 27, 2023
Merged
feat: allow retry successful workflow if nodeFieldSelector is set. Fixes #11020 #11409
terrytangyuan
merged 1 commit into
argoproj:master
from
or-shachar:11020-retry-successful-workflows-cli
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or-shachar
force-pushed
the
11020-retry-successful-workflows-cli
branch
8 times, most recently
from
July 21, 2023 09:41
3d27393
to
9f9732e
Compare
or-shachar
force-pushed
the
11020-retry-successful-workflows-cli
branch
from
July 26, 2023 13:59
9f9732e
to
9c8f14c
Compare
Joibel
reviewed
Jul 26, 2023
or-shachar
force-pushed
the
11020-retry-successful-workflows-cli
branch
2 times, most recently
from
July 26, 2023 15:38
8066658
to
897fcc7
Compare
Signed-off-by: or-shachar <or.shachar@wiz.io>
or-shachar
force-pushed
the
11020-retry-successful-workflows-cli
branch
from
July 26, 2023 17:40
897fcc7
to
da46ab1
Compare
Looks good to me. Thanks @or-shachar |
terrytangyuan
approved these changes
Jul 27, 2023
terrytangyuan
changed the title
feat: cli allow retry successful workflow if nodeFieldSelector is set (Fixed #11020)
feat: cli allow retry successful workflow if nodeFieldSelector is set. Fixes #11020)
Jul 27, 2023
isubasinghe
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
agilgur5
added
the
area/retry-manual
Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries
label
Sep 3, 2023
3 tasks
agilgur5
changed the title
feat: cli allow retry successful workflow if nodeFieldSelector is set. Fixes #11020)
feat: allow retry successful workflow if nodeFieldSelector is set. Fixes #11020
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/cli
The `argo` CLI
area/retry-manual
Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11020
Motivation
As described in #11020 - I want to be able to retry successful workflow, given I specify explicitly
retrySuccessful
and node selector.Modifications
I added a condition to only fail the
FormulateRetryWorkflow
method if the original workflow is not Error/Failed AND eitherrestartSuccessful==False
ornodeFieldSelector
is empty.Verification
I verified it with local deployment + added tests for both cases (retry should fail for a successful run without those extra flags, retry should work for a successful workflow with those flags).
Notes
I'm not completely sure about the error message ("To retry either: (1) workflow must be Failed/Error (2) Provide also restartSuccessful and nodeFieldSelector value"). Too long? understandable?changed it according to @terrytangyuan 's advise 🙏