Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workflow list page crashes for workflow rows without labels #11195

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Jun 10, 2023

This fixes an issue that causes the workflow list page to crash when the workflow is just submitted and does not have labels yet.

./src/app/workflows/components/workflows-row/workflows-row.tsx/WorkflowsRow.prototype.render/WorkflowsRow<@http://localhost:8080/main.ac06adb506164b3d7bc2.js:392200:37
./src/app/workflows/components/workflows-row/workflows-row.tsx/WorkflowsRow.prototype.render@http://localhost:8080/main.ac06adb506164b3d7bc2.js:392199:48
finishClassComponent@http://localhost:8080/main.ac06adb506164b3d7bc2.js:296661:31
updateClassComponent@http://localhost:8080/main.ac06adb506164b3d7bc2.js:296611:44
beginWork@http://localhost:8080/main.ac06adb506164b3d7bc2.js:298121:16
callCallback@http://localhost:8080/main.ac06adb506164b3d7bc2.js:279689:14
invokeGuardedCallbackDev@http://localhost:8080/main.ac06adb506164b3d7bc2.js:279738:16
invokeGuardedCallback@http://localhost:8080/main.ac06adb506164b3d7bc2.js:279793:31
beginWork$1@http://localhost:8080/main.ac06adb506164b3d7bc2.js:302704:28
performUnitOfWork@http://localhost:8080/main.ac06adb506164b3d7bc2.js:301655:12
workLoopSync@http://localhost:8080/main.ac06adb506164b3d7bc2.js:301631:22
performSyncWorkOnRoot@http://localhost:8080/main.ac06adb506164b3d7bc2.js:301257:9
./node_modules/react-dom/cjs/react-dom.development.js/flushSyncCallbackQueueImpl/<@http://localhost:8080/main.ac06adb506164b3d7bc2.js:290590:24
unstable_runWithPriority@http://localhost:8080/main.ac06adb506164b3d7bc2.js:345103:12
runWithPriority$1@http://localhost:8080/main.ac06adb506164b3d7bc2.js:290540:10
flushSyncCallbackQueueImpl@http://localhost:8080/main.ac06adb506164b3d7bc2.js:290585:24
flushSyncCallbackQueue@http://localhost:8080/main.ac06adb506164b3d7bc2.js:290573:3
scheduleUpdateOnFiber@http://localhost:8080/main.ac06adb506164b3d7bc2.js:300700:9
enqueueSetState@http://localhost:8080/main.ac06adb506164b3d7bc2.js:292140:17
./node_modules/react/cjs/react.development.js/Component.prototype.setState@http://localhost:8080/main.ac06adb506164b3d7bc2.js:321916:16
./src/app/workflows/components/workflows-list/workflows-list.tsx/WorkflowsList.prototype.fetchWorkflows/this.listWatch<@http://localhost:8080/main.ac06adb506164b3d7bc2.js:391973:105
./src/app/shared/list-watch.ts/ListWatch/this.retryWatch<@http://localhost:8080/main.ac06adb506164b3d7bc2.js:384399:21
./src/app/shared/retry-observable.ts/RetryObservable.prototype.start/this.subscription<@http://localhost:8080/main.ac06adb506164b3d7bc2.js:384668:23
./node_modules/rxjs/_esm5/internal/Subscriber.js/SafeSubscriber.prototype.__tryOrUnsub@http://localhost:8080/main.ac06adb506164b3d7bc2.js:332770:16
./node_modules/rxjs/_esm5/internal/Subscriber.js/SafeSubscriber.prototype.next@http://localhost:8080/main.ac06adb506164b3d7bc2.js:332708:22
./node_modules/rxjs/_esm5/internal/Subscriber.js/Subscriber.prototype._next@http://localhost:8080/main.ac06adb506164b3d7bc2.js:332654:26
./node_modules/rxjs/_esm5/internal/Subscriber.js/Subscriber.prototype.next@http://localhost:8080/main.ac06adb506164b3d7bc2.js:332631:18
./node_modules/rxjs/_esm5/internal/operators/map.js/MapSubscriber.prototype._next@http://localhost:8080/main.ac06adb506164b3d7bc2.js:337702:26
./node_modules/rxjs/_esm5/internal/Subscriber.js/Subscriber.prototype.next@http://localhost:8080/main.ac06adb506164b3d7bc2.js:332631:18
./src/app/shared/services/requests.ts/</loadEventSource/</eventSource.onmessage@http://localhost:8080/main.ac06adb506164b3d7bc2.js:385084:68

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan enabled auto-merge (squash) June 10, 2023 03:06
Copy link
Contributor

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Glad to see this issue is fixed

@terrytangyuan terrytangyuan merged commit ac9161c into master Jun 20, 2023
@terrytangyuan terrytangyuan deleted the terrytangyuan-patch-2 branch June 20, 2023 16:31
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
jeremyhager pushed a commit to jeremyhager/argo-workflows that referenced this pull request Jul 7, 2023
…oproj#11195)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Jeremy Hager <47301461+jeremyhager@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants