build: devcontainer improvements and documentation #11162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devcontainer json was wrong in my last update. For some reason vscode was fine with it and actioned it. Add the port numbers for devcontainer too, appPort is the only one that works with the CLI. Added some more docs for devcontainer including the CLI Signed-off-by: Alan Clucas <alan@clucas.org>
terrytangyuan
changed the title
terrytangyuan
approved these changes
Jun 2, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
Signed-off-by: Alan Clucas <alan@clucas.org>
jeremyhager
pushed a commit
to jeremyhager/argo-workflows
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Alan Clucas <alan@clucas.org> Signed-off-by: Jeremy Hager <47301461+jeremyhager@users.noreply.github.com>
61 tasks
6 tasks
45 tasks
agilgur5
added
area/build
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improving devcontainer support
Modifications
Devcontainer json was wrong in my last update. For some reason vscode was fine with it and actioned it.
Add the port numbers for devcontainer too, appPort is the only one that works with the CLI.
Added some more docs for devcontainer including the CLI
Verification
Tested with vscode and devcontainer cli.