Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make devcontainer able to pre-commit #11153

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: Make devcontainer able to pre-commit #11153

merged 1 commit into from
May 30, 2023

Commits on May 28, 2023

  1. fix: Make devcontainer able to pre-commit 

    make pre-commit doesn't work in devcontainer, with this commit it does.

This fixes that by
a) Moving GOPATH to /home/vscode/go
b) Installing protoc (apt package protobuf-compiler)
c) Ensuring ~/go is writable (so subdirs can be created)
d) Ensuring /home/vscode/go/bin is on the path too

Using /home/vscode/go rather than /go is necessary when doing all the
protocol malarky due to requirements on subdirectories.

Signed-off-by: Alan Clucas <alan@clucas.org>
    @Joibel
    Joibel committed May 28, 2023
    Configuration menu
    Copy the full SHA
    1054a7d View commit details
    Browse the repository at this point in the history