fix: Disable unreliable test #11105
fix: Disable unreliable test #11105
Conversation
Joibel
force-pushed
the
unreliable-test
branch
2 times, most recently
from
5cf0d9d
to
ea06304
Compare
There was a problem hiding this comment.
There are other ones too. We might want to fix each one of them. #10807
|
Can you do a |
I can't reproduce it. Did it 25 times, and works every time for me. This specific test failure gets me much more frequently than the other ones. Or at least it fails fast, so if another one would fail, this one happens first. |
Are you only interested in fixed tests, or is disabling an option with an issue to investigate and re-enable? |
A bit concerned if it's related to core functionalities. Perhaps we can skip it only in GitHub Actions but enable it locally. |
| }) | ||
| // This test regularly fails in Github Actions CI | ||
| // t.Run("PendingShuttingdownStoppingWf", func(t *testing.T) { | ||
| // // Create and acquire the lock for the first workflow |
There was a problem hiding this comment.
Instead of commenting out, it's probably better to do:
t.Run("PendingShuttingdownStoppingWf", func(t *testing.T) {
t.Skip("This test regularly fails in Github Actions CI")
...
}
I don't know if Github Actions also has any environment variables that it sets, but if so, you could make it a conditional based on that environment variable being there
There was a problem hiding this comment.
This is just skipped in CI now based on GITHUB_ACTIONS=true.
I've done that now. |
The test PendingShuttingdownStoppingWf regularly fails in github actions unit test stage. This should probably be looked at, but for now stop needing quite so many retries to push through simple changes. Signed-off-by: Alan Clucas <alan@clucas.org>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Motivation
The test TestSynchronizationForPendingShuttingdownWfs/PendingShuttingdownStoppingWf regularly fails in github actions unit test stage.
This should probably be looked at, but for now stop needing quite so many retries to push through simple changes.
Modifications
Commented out test with a note on reason why.