-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed path separator in .tgz output artifacts created on windows. Fixes #10562 #11097
Conversation
Signed-off-by: Peter Kögel <peter.koegel@vector.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lippertmarkus Would you mind helping us review this change?
@terrytangyuan names in tar headers need to use forward slashes for the tar archive to extract correctly on both Linux and Windows, so the fix is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…Fixes argoproj#10562 (argoproj#11097) Signed-off-by: Peter Kögel <peter.koegel@vector.com>
…Fixes argoproj#10562 (argoproj#11097) Signed-off-by: Peter Kögel <peter.koegel@vector.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Fixes #10562
Motivation
Output artifacts in .tgz format that are created on Windows result in wrong directory and file structure when unpacked by 7-zip or on Linux.
Example:
Folder structure Windows is
A\B\C.txt
An output artifact in .tgz format is generated from this (on Windows)
The resulting .tgz archive is opened in 7zip
Modifications
When generating the tar archive the pathes that are written to the tar-file's file header are converted to use forward slashes instead of backslashes independent of the current operation systems path format.
Verification
When the above example is repeaded after this fix then 7zip shows the correct folder structure: