docs: Improve documentation on lifecycle hooks #10911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the LifecycleHook documentation to improve clarity on what should and should not work, and how they differ from exit handlers. Improve the links to the examples by making them the `master` versions instead of an historic snapshot. Fix the lifecycle hook example by naming the hooks not `exit`. Signed-off-by: Alan Clucas <alan@clucas.org>
tico24
approved these changes
Apr 14, 2023
terrytangyuan
approved these changes
Apr 14, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
Signed-off-by: Alan Clucas <alan@clucas.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #8954, improve documentation
Update the LifecycleHook documentation to improve clarity on what should and should not work, and how they differ from exit handlers.
Improve the links to the examples by making them the
masterversions instead of an historic snapshot.Fix the lifecycle hook example by naming the hooks not
exit.This is a documentation and examples only change.