-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Immediately release locks by pending workflows that are shutting down. Fixes #10733 #10735
Merged
terrytangyuan
merged 12 commits into
argoproj:master
from
terrytangyuan:fix-lock-terminating-wf
Mar 27, 2023
Merged
fix: Immediately release locks by pending workflows that are shutting down. Fixes #10733 #10735
terrytangyuan
merged 12 commits into
argoproj:master
from
terrytangyuan:fix-lock-terminating-wf
Mar 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…argoproj#10733 Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
jessesuen
reviewed
Mar 23, 2023
terrytangyuan
changed the title
fix: Release locks by terminating pending workflows immediately. Fixes #10733
fix: Immediately release locks by pending workflows that are shutting down. Fixes #10733
Mar 23, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
33 tasks
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
alexec
approved these changes
Mar 24, 2023
jessesuen
reviewed
Mar 24, 2023
Based on our discussion, the agreed logic shall be:
|
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@jessesuen Updated the PR based on our discussion. |
jessesuen
reviewed
Mar 24, 2023
jessesuen
reviewed
Mar 24, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
jessesuen
approved these changes
Mar 27, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
… down. Fixes argoproj#10733 (argoproj#10735) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
agilgur5
reviewed
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10733.