Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve documentation on loops #10661

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented Mar 10, 2023

The loops documentation is 'by example' only. I have attempted to improve this to explain what is going on, and why someone might use each form of loops

This is a documentation only change. The examples are unchanged.

Copy link
Member

@tico24 tico24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit from me.

docs/walk-through/loops.md Outdated Show resolved Hide resolved
Signed-off-by: Alan Clucas <alan@clucas.org>
@Joibel Joibel force-pushed the loops-docs branch 2 times, most recently from 3e22315 to 68ae239 Compare March 10, 2023 10:26
Signed-off-by: Alan Clucas <alan@clucas.org>
@Joibel Joibel marked this pull request as ready for review March 10, 2023 10:49
Signed-off-by: Alan Clucas <alan@clucas.org>
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrytangyuan terrytangyuan merged commit 941f0b6 into argoproj:master Mar 14, 2023
@Joibel Joibel deleted the loops-docs branch March 17, 2023 16:16
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
Signed-off-by: Alan Clucas <alan@clucas.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants