-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove kubectl binary from argoexec #10550
Conversation
PersistentPreRun: func(cmd *cobra.Command, args []string) { | ||
initConfig() | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change to avoid conflicting klog flag byflag redefined: log_dir
.
@@ -216,7 +216,7 @@ func TestResourceExecRetry(t *testing.T) { | |||
|
|||
_, _, _, err := we.ExecResource("", "../../examples/hello-world.yaml", nil) | |||
assert.Error(t, err) | |||
assert.Equal(t, "no more retries i/o timeout", err.Error()) | |||
assert.Contains(t, err.Error(), "no more retries") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message will change slightly.
Relax the assertion.
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
e7afc4b
to
11dfe4e
Compare
@@ -63,10 +63,12 @@ require ( | |||
gopkg.in/jcmturner/gokrb5.v5 v5.3.0 | |||
k8s.io/api v0.24.3 | |||
k8s.io/apimachinery v0.24.3 | |||
k8s.io/cli-runtime v0.24.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.24.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to do all the k8s.io/* bumps on other PRs.
I would keep this PR changes small.
k8s.io/client-go v0.24.3 | ||
k8s.io/gengo v0.0.0-20220613173612-397b4ae3bce7 | ||
k8s.io/klog/v2 v2.60.1 | ||
k8s.io/kube-openapi v0.0.0-20220627174259-011e075b9cb8 | ||
k8s.io/kubectl v0.24.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.24.10
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
related #7797
Include the kubectl module in argoexec.
The high-level kubectl package API is deeply coupled with cobra, so we need a hack to temporarily rewrite os.Args.
Please do not open a pull request until you have checked ALL of these:
make pre-commit -B
to fix codegen and lint problems.If changes were requested, and you've made them, dismiss the review to get it reviewed again.