Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest images not built for 20 days #2983

Closed
alexec opened this issue May 8, 2020 · 2 comments · Fixed by #2984
Closed

latest images not built for 20 days #2983

alexec opened this issue May 8, 2020 · 2 comments · Fixed by #2984
Assignees
@alexec
Labels
type/bug

Comments

@alexec
Copy link
Contributor

alexec commented May 8, 2020

Why not?

https://hub.docker.com/layers/argoproj/workflow-controller/latest/images/sha256-d6160e4078296ab5ae9cfd9c4a554275151428c8d5f443a7213fb6e76d553f17?context=repo

@jessesuen @alexmt how are these built please?
@alexec alexec added the type/bug label May 8, 2020
@alexec
Copy link
Contributor Author

alexec commented May 8, 2020

https://hub.docker.com/repository/registry-1.docker.io/argoproj/workflow-controller/builds/5c182a1c-e6f7-4d56-b9b3-30c2e65b4b55

Step 34/42 : RUN git diff --exit-code
---> Running in b50c8833ee89
diff --git a/hooks/README.md b/hooks/README.md
old mode 100644
new mode 100755
The command '/bin/sh -c git diff --exit-code' returned a non-zero code: 1

Why is hooks different?

@alexec alexec self-assigned this May 8, 2020
alexec added a commit to alexec/argo-workflows that referenced this issue May 8, 2020
@alexec
build: Fix Docker build. Fixes argoproj#2983
2ef02eb
@alexec
Copy link
Contributor Author

alexec commented May 8, 2020

Presumably Docker Hub blindly decides to make everything in that directory executable and that results in the diff.

@alexec alexec mentioned this issue May 8, 2020
Merged
6 tasks
simster7 pushed a commit that referenced this issue May 9, 2020
@alexec
build: Fix Docker build. Fixes #2983 (#2984)
76aca49
@alexec alexec changed the title latest images not builds for 20 days latest images not built for 20 days May 10, 2020
@alexec alexec reopened this May 10, 2020
alexec added a commit to alexec/argo-workflows that referenced this issue May 11, 2020
@alexec
build: Fix Docker build. Fixes argoproj#2983 (argoproj#2984)
af01263
@alexec alexec closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Fix Docker build. Fixes #2983 alexec/argo-workflows
1 participant
@alexec