-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
whalesay
does not support arm64 and should not be used as a workflow example
#11858
Comments
I've been running whalesay on arm64 without issues. |
You are using |
@terrytangyuan It works with Docker on MacOS, but not with containerd on Kubernetes. I assume that Docker runs the container with x86 emulation. The template uses A simple alternative is: spec:
entrypoint: echotest
templates:
- name: echotest
container:
image: alpine
command: ["sh","-c"]
args: ["echo","hello"] |
Would you like to submit a PR to update the examples? |
It seems |
But also, I experience this frequently. It typically takes me 5 minutes to realize that the problem is lack of arm64 support, but I'm getting used to it. I assume others will have the same experience, so I guess it's low priority. I'm happy to close the issue. |
@erikschul as mentioned above, we'll happily take a PR to update the examples to a similar image that is cross-architecture compatible |
We can also use argosay image which is something we can manage https://github.com/argoproj/argo-workflows/tree/master/test/e2e/images/argosay/v2 |
Cool. I'll take a look when I'm more familiar with Argo Workflows. |
Despite #10435, an argoproj/argosay |
For reference, I threw up a tweet at Docker to try and get their attention about the issues with
Yea there's apparently no CI process for that and it was last manually pushed: #11613 (comment). I'd prefer to remove |
PRs welcome for a replacement with another minimal trusted image that can do a simple echo, such as |
What about |
Docker Support mentioned that in docker/whalesay#6 (comment), but as I wrote there, it prints out Docker CLI usage instructions after the "hello", so that would be very confusing to see in an example. |
Another option would be to resurrect argosay. |
Reducing the code surface is definitely preferable, and |
Yeah, it's unnecessary, but we could get a cute octopus argonaut to say stuff 😄 Reducing things is better. Marking as a good first issue. Two PRs could be done:
|
Could also split the I didn't mark it as a good first issue as |
I'm going to tackle this since it is a very confusing issue to new users and has gotten a couple related issues too (on manifest v1, for instance). It also does have a lot of usage as I mentioned above so is not the simplest issue either, and no one's picked it up since it was marked as a |
Pre-requisites
:latest
What happened/what you expected to happen?
Tag for arm64 doesn't exist:
https://hub.docker.com/r/docker/whalesay/tags
Version
irrelevant
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
When following this guide:
https://argoproj.github.io/argo-workflows/quick-start/
which uses
https://raw.githubusercontent.com/argoproj/argo-workflows/master/examples/hello-world.yaml
which uses whalesay
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: