Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated - Static files embed library #11654

Open
sonbui00 opened this issue Aug 23, 2023 · 1 comment · May be fixed by #11707
Open

Deprecated - Static files embed library #11654

sonbui00 opened this issue Aug 23, 2023 · 1 comment · May be fixed by #11707
Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/tech-debt

Comments

@sonbui00
Copy link
Member

Summary

From #11644 , lib for embed static files https://github.com/bouk/staticfiles is deprecated now. It should be replaced with Go standard library

Use Cases

  • maintainable code

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@sonbui00 sonbui00 added the type/feature Feature request label Aug 23, 2023
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Aug 23, 2023
@agilgur5
Copy link
Member

agilgur5 commented Aug 23, 2023 •
edited
Loading

As an example for anyone looking to take this on, Argo CD has a tiny embed.go file in the ui/ directory with the new go:embed directive

sonbui00 added a commit to sonbui00/argo-workflows that referenced this issue Aug 29, 2023
@sonbui00
fix: bouk/staticfiles is deprecated argoproj#11654
8ac0287 
Signed-off-by: Son Bui <sonbv00@gmail.com>
@sonbui00 sonbui00 linked a pull request Aug 29, 2023 that will close this issue
Open
sonbui00 added a commit to sonbui00/argo-workflows that referenced this issue Aug 29, 2023
@sonbui00
fix: bouk/staticfiles is deprecated argoproj#11654
542605d 
Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/argo-workflows that referenced this issue Aug 29, 2023
@sonbui00
fix: bouk/staticfiles is deprecated argoproj#11654
a2dc0b1 
Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/argo-workflows that referenced this issue Aug 30, 2023
@sonbui00
fix: bouk/staticfiles is deprecated argoproj#11654
5e6545e 
Signed-off-by: Son Bui <sonbv00@gmail.com>
This was referenced Oct 24, 2023
Closed
Closed
@agilgur5 agilgur5 mentioned this issue Nov 7, 2023
Closed
6 tasks
sonbui00 added a commit to sonbui00/argo-workflows that referenced this issue Jul 3, 2024
@sonbui00
fix: bouk/staticfiles is deprecated argoproj#11654
70d3380 
Signed-off-by: Son Bui <sonbv00@gmail.com>
sonbui00 added a commit to sonbui00/argo-workflows that referenced this issue Jul 4, 2024
@sonbui00
fix: bouk/staticfiles is deprecated argoproj#11654
1c33117 
Signed-off-by: Son Bui <sonbv00@gmail.com>
@agilgur5 agilgur5 added type/tech-debt and removed type/feature Feature request labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace deprecated bouk/staticfiles with native Go embed. fixes #11654 sonbui00/argo-workflows
2 participants
@agilgur5 @sonbui00