fix: Flakey TestDataTransformationArtifactRepositoryRef (#5226)

Signed-off-by: Simon Behar <simbeh7@gmail.com>
argoproj · Feb 26, 2021 · fb19af1 · fb19af1
1 parent 6412bc6
commit fb19af1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/test/e2e/fixtures/e2e_suite.go b/test/e2e/fixtures/e2e_suite.go
@@ -74,10 +74,7 @@ func (s *E2ESuite) BeforeTest(string, string) {
 	s.DeleteResources()
 }
 
-var (
-	foreground = metav1.DeletePropagationForeground
-	background = metav1.DeletePropagationBackground
-)
+var foreground = metav1.DeletePropagationForeground
 
 func (s *E2ESuite) DeleteResources() {
 	hasTestLabel := metav1.ListOptions{LabelSelector: Label}
@@ -95,7 +92,7 @@ func (s *E2ESuite) DeleteResources() {
 
 	ctx := context.Background()
 	for _, r := range resources {
-		err := s.dynamicFor(r).DeleteCollection(ctx, metav1.DeleteOptions{PropagationPolicy: &background}, hasTestLabel)
+		err := s.dynamicFor(r).DeleteCollection(ctx, metav1.DeleteOptions{PropagationPolicy: &foreground}, hasTestLabel)
 		s.CheckError(err)
 	}
 

diff --git a/test/e2e/testdata/data-transformation-artifact-repository-ref.yaml b/test/e2e/testdata/data-transformation-artifact-repository-ref.yaml
@@ -1,7 +1,7 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Workflow
 metadata:
-  name: data-transformation
+  name: data-transformation-artifact-repository-ref
   labels:
     argo-e2e: "true"
 spec: