fix(ui): Only redirect/reload to wf list page when wf deletion succee…

…ds (#11676) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
argoproj · Aug 25, 2023 · f18b339 · f18b339
1 parent 39ff284
commit f18b339
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/ui/src/app/workflows/components/workflow-details/workflow-details.tsx b/ui/src/app/workflows/components/workflow-details/workflow-details.tsx
@@ -197,10 +197,12 @@ export const WorkflowDetails = ({history, location, match}: RouteComponentProps<
                                         if (isArchivedWorkflow(workflow) && (globalDeleteArchived || !isWorkflowInCluster(workflow))) {
                                             services.workflows.deleteArchived(workflow.metadata.uid, workflow.metadata.namespace).catch(setError);
                                         }
-                                        navigation.goto(uiUrl(`workflows/${workflow.metadata.namespace}`));
-                                        // TODO: This is a temporary workaround so that the list of workflows
-                                        //  is correctly displayed. Workflow list page needs to be more responsive.
-                                        window.location.reload();
+                                        if (error === null) {
+                                            navigation.goto(uiUrl(`workflows/${workflow.metadata.namespace}`));
+                                            // TODO: This is a temporary workaround so that the list of workflows
+                                            //  is correctly displayed. Workflow list page needs to be more responsive.
+                                            window.location.reload();
+                                        }
                                     }
                                 });
                         } else if (workflowOperation.title === 'RESUBMIT') {