fix(controller): Fix sync manager panic. Fixes #5939 (#5991)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
argoproj · May 25, 2021 · a99d5b8 · a99d5b8
1 parent 80f8473
commit a99d5b8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/workflow/sync/sync_manager.go b/workflow/sync/sync_manager.go
@@ -258,9 +258,10 @@ func (cm *Manager) ReleaseAll(wf *wfv1.Workflow) bool {
 
 	for _, node := range wf.Status.Nodes {
 		if node.SynchronizationStatus != nil && node.SynchronizationStatus.Waiting != "" {
-			lock := cm.syncLockMap[node.SynchronizationStatus.Waiting]
-			lock.removeFromQueue(getHolderKey(wf, node.ID))
-
+			lock, ok := cm.syncLockMap[node.SynchronizationStatus.Waiting]
+			if ok {
+				lock.removeFromQueue(getHolderKey(wf, node.ID))
+			}
 			node.SynchronizationStatus = nil
 			wf.Status.Nodes[node.ID] = node
 		}