fix(controller): More emissary minor bugs (#5193)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
argoproj · Feb 25, 2021 · 8acdb1b · 8acdb1b
1 parent e282fcc
commit 8acdb1b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/config/config.go b/config/config.go
@@ -107,7 +107,7 @@ type Config struct {
 	InitialDelay metav1.Duration `json:"initialDelay,omitempty"`
 
 	// The command/args for each image, needed when the command is not specified and the emissary executor is used.
-	// https://argoproj.github.io/argo-workflows/workflow-executors/#emissary
+	// https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary
 	Images map[string]Image `json:"images,omitempty"`
 }
 

diff --git a/docs/workflow-controller-configmap.yaml b/docs/workflow-controller-configmap.yaml
@@ -136,7 +136,7 @@ data:
   kubeletInsecure: false
 
   # The command/args for each image, needed when the command is not specified and the emissary executor is used.
-  # https://argoproj.github.io/argo-workflows/workflow-executors/#emissary
+  # https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary
   images: |
     argoproj/argosay:v1:
       command: [cowsay]

diff --git a/hack/test-examples.sh b/hack/test-examples.sh
@@ -1,8 +1,7 @@
 #!/usr/bin/env bash
 set -eu -o pipefail
 
-./dist/argo delete -l workflows.argoproj.io/test
-
 grep -lR 'workflows.argoproj.io/test' examples/* | while read f ; do
-    ./dist/argo submit --watch --verify $f
+  ./dist/argo delete -l workflows.argoproj.io/test
+  ./dist/argo submit --watch --verify $f
 done
diff --git a/workflow/controller/workflowpod.go b/workflow/controller/workflowpod.go
@@ -307,7 +307,7 @@ func (woc *wfOperationCtx) createWorkflowPod(ctx context.Context, nodeName strin
 					}
 				}
 				if len(c.Command) == 0 {
-					return nil, fmt.Errorf("when using the emissary executor you must either explicitly specify the command, or list the image's command in the index: https://argoproj.github.io/argo-workflows/workflow-executors/#emissary")
+					return nil, fmt.Errorf("when using the emissary executor you must either explicitly specify the command, or list the image's command in the index: https://argoproj.github.io/argo-workflows/workflow-executors/#emissary-emissary")
 				}
 				c.Command = append([]string{"/var/run/argo/argoexec", "emissary", "--"}, c.Command...)
 			}
@@ -542,13 +542,8 @@ func (woc *wfOperationCtx) createEnvVars() []apiv1.EnvVar {
 		execEnvVars = append(execEnvVars, woc.controller.Config.Executor.Env...)
 	}
 	switch woc.getContainerRuntimeExecutor() {
-	case common.ContainerRuntimeExecutorK8sAPI:
 	case common.ContainerRuntimeExecutorKubelet:
 		execEnvVars = append(execEnvVars,
-			apiv1.EnvVar{
-				Name:  common.EnvVarContainerRuntimeExecutor,
-				Value: woc.getContainerRuntimeExecutor(),
-			},
 			apiv1.EnvVar{
 				Name: common.EnvVarDownwardAPINodeIP,
 				ValueFrom: &apiv1.EnvVarSource{