Issue #1190 - Fix incorrect retry node handling (#1208)

argoproj · Feb 13, 2019 · 8aae293 · 8aae293
1 parent f1797f7
commit 8aae293
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/workflow/controller/dag.go b/workflow/controller/dag.go
@@ -106,6 +106,10 @@ func (d *dagContext) assessDAGPhase(targetTasks []string, nodes map[string]wfv1.
 }
 
 func hasMoreRetries(node *wfv1.NodeStatus, wf *wfv1.Workflow) bool {
+	if node.Phase == wfv1.NodeSucceeded {
+		return false
+	}
+
 	if len(node.Children) == 0 {
 		return true
 	}