Skip to content

Commit

Permalink
ci: remove flaky assertion from hook e2e test (#12007)
Browse files Browse the repository at this point in the history
  • Loading branch information
toyamagu-2021 authored Oct 15, 2023
1 parent a04d055 commit 4aa9011
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/e2e/hooks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,10 @@ spec:
}).ExpectWorkflowNode(func(status v1alpha1.NodeStatus) bool {
return strings.Contains(status.Name, "step-2.hooks.running")
}, func(t *testing.T, status *v1alpha1.NodeStatus, pod *apiv1.Pod) {
assert.Equal(t, v1alpha1.NodeSucceeded, status.Phase)
// TODO: Temporarily comment out this assertion since it's flaky:
// The running hook is occasionally not triggered. Possibly because the step finishes too quickly
// while the controller did not get a chance to trigger this hook.
//assert.Equal(t, v1alpha1.NodeSucceeded, status.Phase)
})
}

Expand Down

0 comments on commit 4aa9011

Please sign in to comment.