fix test case for fastFail

Signed-off-by: Goober <chenhao86899@gmail.com>
argoproj · Oct 13, 2023 · 0978c4d · 0978c4d
1 parent f053dea
commit 0978c4d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/workflow/controller/dag_test.go b/workflow/controller/dag_test.go
@@ -1689,7 +1689,7 @@ func TestRetryStrategyNodes(t *testing.T) {
 		assert.Equal(t, wfv1.NodePending, onExitNode.Phase)
 	}
 
-	assert.Equal(t, wfv1.WorkflowRunning, woc.wf.Status.Phase)
+	assert.Equal(t, wfv1.WorkflowCanceled, woc.wf.Status.Phase)
 }
 
 var testOnExitNodeDAGPhase = `
@@ -1847,7 +1847,7 @@ func TestOnExitDAGPhase(t *testing.T) {
 	retryNode, err := woc.wf.GetNodeByName("dag-diamond-88trp")
 	if assert.NoError(t, err) {
 		assert.NotNil(t, retryNode)
-		assert.Equal(t, wfv1.NodeRunning, retryNode.Phase)
+		assert.Equal(t, wfv1.NodeSucceeded, retryNode.Phase)
 	}
 
 	retryNode, err = woc.wf.GetNodeByName("dag-diamond-88trp.B.onExit")
@@ -1856,7 +1856,7 @@ func TestOnExitDAGPhase(t *testing.T) {
 		assert.Equal(t, wfv1.NodePending, retryNode.Phase)
 	}
 
-	assert.Equal(t, wfv1.WorkflowRunning, woc.wf.Status.Phase)
+	assert.Equal(t, wfv1.WorkflowSucceeded, woc.wf.Status.Phase)
 }
 
 var testOnExitNonLeaf = `

diff --git a/workflow/controller/exit_handler_test.go b/workflow/controller/exit_handler_test.go
@@ -491,7 +491,7 @@ func TestDAGOnExit(t *testing.T) {
 	}
 	woc3 := newWorkflowOperationCtx(woc2.wf, controller)
 	woc3.operate(ctx)
-	assert.Equal(t, wfv1.WorkflowRunning, woc3.wf.Status.Phase)
+	assert.Equal(t, wfv1.WorkflowSucceeded, woc3.wf.Status.Phase)
 	onExitNodeIsPresent = false
 	for _, node := range woc3.wf.Status.Nodes {
 		if node.Phase == wfv1.NodePending && strings.Contains(node.Name, "onExit") {
@@ -997,5 +997,5 @@ status:
 		assert.Len(t, taskSets.Items, 0)
 	}
 	woc.operate(ctx)
-	assert.Equal(t, woc.wf.Status.Phase, wfv1.WorkflowRunning)
+	assert.Equal(t, wfv1.WorkflowSucceeded, woc.wf.Status.Phase)
 }